-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] SPELLFLAG_ONLYSELF #1171
Comments
Honestly we already have that, if you don't give any targ flag, the spell automatically cast on yourself directly, eq;
If you cast invisibilty with that flags, you can see it cast on himself directly. You just need to remove targ flags from spells to make it only self-cast. |
This may happen for spells without effect_id, but for spells with effect_id, removing all targeting flags will cause the spell effect to not occur at all. eg; protection spell or reactive armor spell |
Couldn't this be solved by using effect_id also if there's not a target flag? |
Honestly I haven't deeply checked this, but effect id not trigger when you don't have targ flag, but if you think flag is unnecessary, I could take a look on it more deeply in couple of hours to see why effect id not trigger when player not using target. |
Okay as I tested a bit and take a look for it, seems like SPELLFLAG_FX_TARG flag enough for effect. We don't need spellflag_targ_onlyself, I revert back the update and update the pr. |
Closing as the feature is already there, as commented. |
There is a spell flag for
SPELLFLAG_TARG_NOSELF
, in addition to spells that will only be allowed to be cast on ourselves, another flag likeSPELLFLAG_TARG_ONLYSELF
can be added.Note: When we remove all the spell flags of the spell, the target does not appear in the spell and we can only apply it directly to ourselves, but then the spell effects do not appear.
The text was updated successfully, but these errors were encountered: