Make code less "error prone"

Author: rowleya

SpiNNaker-allocserv/src/main/java/uk/ac/manchester/spinnaker/alloc/allocator/Spalloc.java

@@ -57,6 +57,7 @@
 
 import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.google.errorprone.annotations.FormatMethod;
+import com.google.errorprone.annotations.MustBeClosed;
 import com.google.errorprone.annotations.concurrent.GuardedBy;
 
 import uk.ac.manchester.spinnaker.alloc.SpallocProperties.AllocatorProperties;
@@ -1746,6 +1747,7 @@ public TransceiverInterface getTransceiver() throws IOException,
 		}
 
 		@Override
+		@SuppressWarnings("MustBeClosed")
 		public FastDataIn getFastDataIn(CoreLocation gathererCore, IPTag iptag)
 				throws ProcessException, IOException, InterruptedException {
 			var fdi = rememberer.getFastDataIn(id, iptag.getDestination());
@@ -1758,6 +1760,7 @@ public FastDataIn getFastDataIn(CoreLocation gathererCore, IPTag iptag)
 		}
 
 		@Override
+		@SuppressWarnings("MustBeClosed")
 		public Downloader getDownloader(IPTag iptag)
 				throws ProcessException, IOException, InterruptedException {
 			var downloader = rememberer.getDownloader(id,

SpiNNaker-allocserv/src/main/java/uk/ac/manchester/spinnaker/alloc/allocator/SpallocAPI.java

@@ -42,6 +42,7 @@
 import org.springframework.security.access.prepost.PreAuthorize;
 
 import com.google.errorprone.annotations.Keep;
+import com.google.errorprone.annotations.MustBeClosed;
 
 import uk.ac.manchester.spinnaker.alloc.compat.V1CompatService;
 import uk.ac.manchester.spinnaker.alloc.model.BoardCoords;
@@ -1007,6 +1008,7 @@ TransceiverInterface getTransceiver()
 		 * @throws IOException if there is an issue communicating.
 		 * @throws InterruptedException if the operation is interrupted.
 		 */
+		@MustBeClosed
 		FastDataIn getFastDataIn(CoreLocation gathererCore, IPTag iptag)
 				throws ProcessException, IOException, InterruptedException;
 
@@ -1019,6 +1021,7 @@ FastDataIn getFastDataIn(CoreLocation gathererCore, IPTag iptag)
 		 * @throws IOException if there is an issue communicating.
 		 * @throws InterruptedException if the operation is interrupted.
 		 */
+		@MustBeClosed
 		Downloader getDownloader(IPTag iptag)
 				throws ProcessException, IOException, InterruptedException;
 	}

SpiNNaker-allocserv/src/main/java/uk/ac/manchester/spinnaker/alloc/web/SpallocServiceAPIImplBuilder.java

@@ -316,6 +316,7 @@ public void readDataFromJob(int x, int y, long address, int size,
 		}
 
 		@Override
+		@SuppressWarnings("MustBeClosed")
 		public void fastDataWrite(@ValidX int gatherX, @ValidY int gatherY,
 				@Positive int gatherP, @ValidX int ethX,
 				@ValidY int ethY, @IPAddress String ethAddress, int iptag,
@@ -333,6 +334,7 @@ public void fastDataWrite(@ValidX int gatherX, @ValidY int gatherY,
 		}
 
 		@Override
+		@SuppressWarnings("MustBeClosed")
 		public void fastDataRead(@ValidX int gatherX, @ValidY int gatherY,
 				@ValidX int ethX, @ValidY int ethY,
 				@IPAddress String ethAddress, int iptag,

SpiNNaker-comms/src/main/java/uk/ac/manchester/spinnaker/protocols/download/Downloader.java

@@ -46,7 +46,7 @@
  *
  * @author Donal Fellows
  */
-public class Downloader {
+public class Downloader implements AutoCloseable {
 
 	/** The maximum number of times to retry. */
 	private static final int TIMEOUT_RETRY_LIMIT = 15;
@@ -131,6 +131,7 @@ public Downloader(IPTag iptag)
 		conn = new GatherDownloadConnection(iptag);
 	}
 
+	@Override
 	public void close() throws IOException {
 		conn.close();
 	}

SpiNNaker-front-end/src/main/java/uk/ac/manchester/spinnaker/front_end/download/DataGatherer.java

@@ -287,6 +287,7 @@ private void parallel(Stream<SimpleCallable> tasks) throws IOException,
 	 * @throws InterruptedException
 	 *             If communications are interrupted.
 	 */
+	@SuppressWarnings("MustBeClosed")
 	private void fastDownload(List<WorkItems> work,
 			ChipLocation gathererChip, IPTag ipTag)
 			throws IOException, StorageException,
@@ -321,6 +322,9 @@ private void fastDownload(List<WorkItems> work,
 				}
 			}
 		}
+		if (downloader != null) {
+			downloader.close();
+		}
 	}
 
 	private void sanityCheck(List<Gather> gatherers) {

SpiNNaker-front-end/src/main/java/uk/ac/manchester/spinnaker/front_end/download/DataReceiver.java

@@ -28,6 +28,8 @@
 
 import org.slf4j.Logger;
 
+import com.google.errorprone.annotations.MustBeClosed;
+
 import uk.ac.manchester.spinnaker.front_end.BasicExecutor;
 import uk.ac.manchester.spinnaker.front_end.BoardLocalSupport;
 import uk.ac.manchester.spinnaker.front_end.download.request.Placement;
@@ -73,6 +75,8 @@ public class DataReceiver extends BoardLocalSupport implements AutoCloseable {
 	 * @throws StorageException
 	 *           If the database access fails.
 	 */
+	@MustBeClosed
+	@SuppressWarnings("MustBeClosed")
 	public DataReceiver(Machine machine, BufferManagerStorage storage)
 			throws IOException, StorageException, SpinnmanException,
 			InterruptedException {

SpiNNaker-front-end/src/main/java/uk/ac/manchester/spinnaker/front_end/dse/FastExecuteDataSpecification.java

@@ -91,6 +91,7 @@ public class FastExecuteDataSpecification extends ExecuteDataSpecification {
 	 *             this constructor should not be doing that!
 	 */
 	@MustBeClosed
+	@SuppressWarnings("MustBeClosed")
 	public FastExecuteDataSpecification(
 			Machine machine, List<Gather> gatherers, File reportDir,
 			DSEDatabaseEngine db) throws IOException, InterruptedException,
@@ -187,6 +188,7 @@ private List<RegionInfo> loadBoardTables(Ethernet board, DSEStorage storage)
 		return regionsToWrite;
 	}
 
+	@SuppressWarnings("MustBeClosed")
 	private void loadBoardData(Gather gather, List<RegionInfo> regionsToWrite)
 			throws IOException, StorageException, ProcessException,
 			InterruptedException {
@@ -206,6 +208,9 @@ private void loadBoardData(Gather gather, List<RegionInfo> regionsToWrite)
 						core, info.pointer, info.content);
 			}
 		}
+		if (fastDataIn != null) {
+			fastDataIn.close();
+		}
 	}
 
 	private HasChipLocation getBoardLocalDestination(

SpiNNaker-front-end/src/main/java/uk/ac/manchester/spinnaker/front_end/dse/HostExecuteDataSpecification.java

@@ -64,6 +64,7 @@ public class HostExecuteDataSpecification extends ExecuteDataSpecification {
 	 *             this constructor should not be doing that!
 	 */
 	@MustBeClosed
+	@SuppressWarnings("MustBeClosed")
 	public HostExecuteDataSpecification(
 			Machine machine, DSEDatabaseEngine db)
 			throws IOException, InterruptedException,