Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to NNBD #236

Closed
pq opened this issue Dec 11, 2020 · 11 comments
Closed

Migrate to NNBD #236

pq opened this issue Dec 11, 2020 · 11 comments
Assignees

Comments

@pq
Copy link
Contributor

pq commented Dec 11, 2020

As the ecosystem moves towards embracing null-safety, it'd be great to get this package migrated.

See: https://dart.dev/null-safety

Happy to help if you hit any snags!

@github-actions
Copy link

👋 Thanks for reporting! @robrbecker will take a look.

@robrbecker
Copy link
Member

I agree! I gave it a once over a couple weeks ago but there were still dependencies that needed to upgrade first. I'll be sure to get it updated as soon as I can. Thanks for reaching out!

@robrbecker robrbecker self-assigned this Dec 11, 2020
@robrbecker
Copy link
Member

Looks like it's close to being unblocked. Just waiting on http
image

@pq
Copy link
Contributor Author

pq commented Dec 12, 2020

I know folks are actively looking at http. Maybe @natebosch?

I see a tracking issue here: dart-lang/http#501

Thanks a million for taking a look @robrbecker!

@robrbecker
Copy link
Member

The http package has a null safe release now. I'll take another shot at converting this package this week.

@pq
Copy link
Contributor Author

pq commented Feb 2, 2021

Awesome. Thanks!

@robrbecker
Copy link
Member

I put up an initial draft PR here #244
@pq would you be up for giving it a once over?

@pq
Copy link
Contributor Author

pq commented Feb 16, 2021

sorry for the slow reply! fighting a few fires here but will happily take a look in the next few days. thanks for pushing on this!

@pq
Copy link
Contributor Author

pq commented Feb 17, 2021

Thanks so much for pushing on this! I've done some integrating and while I haven't dug deeply there are some spots where we're getting nullable results and ideally they'd be non-null. For example, it would be fantastic if Issue could guarantee a non-null url, title, etc. Not sure about implications.

@bsutton
Copy link
Contributor

bsutton commented Feb 25, 2021

At some point can we get a version released without the -nullsafety. Google is calling for package maintainers to publish a 'pre-release' version such as 7.1.0.
Usage of the nullsaftey designation results in warnings when a dependant package attempts to publish a pre-release.

@robrbecker
Copy link
Member

Closing this issue. Null safe versions are 8+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants