Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform loader-specific pre-save validation before opening a file #189

Closed
zml2008 opened this issue Feb 1, 2021 · 0 comments
Closed

Perform loader-specific pre-save validation before opening a file #189

zml2008 opened this issue Feb 1, 2021 · 0 comments

Comments

@zml2008
Copy link
Member

zml2008 commented Feb 1, 2021

Currently, loaders are passed an opened Writer before they have any chance to validate that the provided node is a valid format, and do their validation in the write() method. This means that if validation fails, the target file will be erased.

We can add another extension point to AbstractConfiguration loader to perform pre-processing, which will allow us to preserve existing data, even when trying to write invalid data.

@zml2008 zml2008 added this to the 4.1 milestone Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant