Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing toString override in GlobalProperties$Keys causes incorrectly named Keys due to string concatenation with existing Keys #562

Closed
DJtheRedstoner opened this issue Feb 7, 2022 · 1 comment
Closed

Missing toString override in GlobalProperties$Keys causes incorrectly named Keys due to string concatenation with existing Keys #562

DJtheRedstoner opened this issue Feb 7, 2022 · 1 comment
Labels
bug core

Comments

@DJtheRedstoner
Copy link

The lack of a toString override in GlobalProperties$Keys makes the following code (and other similar instances) create a key similar to org.spongepowered.asm.launch.GlobalProperties$Keys@239b0f9d.default.

Mixin/src/main/java/org/spongepowered/asm/mixin/MixinEnvironment.java

Line 1096 in 155314e

this.configsKey = Keys.of(GlobalProperties.Keys.CONFIGS + "." + this.phase.name.toLowerCase(Locale.ROOT));

@Mumfrey
Copy link
Member

Mumfrey commented Feb 8, 2022

Thanks for opening this, marked as bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mumfrey @DJtheRedstoner