Add debug CLI config that prevents logging from taking out values for privacy

[mainrs]

This would be a nice to have feature to make debugging BadCredentials during the login step of the daemon easier to debug. It would allow people to see their password and username used within the configuration.

How to implement:

• Add a boolean flag (name is up for discussion) to the SharedConfigValues struct.
• Check for the flag in this method and change the values accordingly.

[olavbm]

I'd like to contribute here.

[mainrs]

Someone created a PR linked above (#360). We came to the conclusion that it would be better to move our Debug implementation one scope up in the chain. See #360 (comment) for more information.

I am not sure how much experience you have with Rust. This might be a harder issue to resolve than other issues I marked with “good first issue”. Feel free to give it a try though!

You can open a new PR after you implemented it. Make sure to link back to this issue and the PR I mentioned above.

For now I’ll assign you to the issue. It you have problems implementing it let me know and I’ll tackle this one down.

[mainrs]

Correction on my part. The Debug implementation doesn’t need to be moved. CliConfig just needs one too that calls the one of SharedConfigValues.

I am typing this up from my memory. So if you think I am talking gibberish, please let me know :)
I just don’t want you people wasting time on an issue that might actually not work as I imagine it right now. That’s why I wrote in #360 that I’ll take a closer look myself :)

[Icelk]

Hi @sirwindfield ! Can I help out with this issue?
Should I do as you stated in the first comment?

[robinvd]

@IsELK yes that should do it! If you need any help you can ping me here or in a pr

[jackvstrickland]

Hi @sirwindfield ! Can I help out with this issue?
Should I do as you stated in the first comment?

have you started yet? If not, I wouldn't mind taking a crack at it

[mainrs]

I'm not actively developing anymore, just keeping a watchful eye around here ;) I've assigned @IsELK as they offered their help first. If we do not receive any updates you can gladly take over @jackvstrickland.

In the meantime, there are other issues that need help :)

[Icelk]

Hi @jackvstrickland

have you started yet? If not, I wouldn't mind taking a crack at it

I am. It will be done this week, probably on Friday.