config option for shuffle

[SilPan]

spotifyd disables shuffle (at least) on every restart.

I usually have shuffle turned on.

So it would be cool if spotifyd could either preserve the status of if shuffle is enabled, or have a config/commandline option to set an initial value if shuffle should be enabled.

From what I have seen documented here https://developer.spotify.com/documentation/web-api/reference/#endpoint-toggle-shuffle-for-users-playback, this should be easy to implement.

I am aware of #626, but the issue got closed and tagged with wontfix due to inactivity, as far as I can see.
It sais something sbout a todo list there?

[robinvd]

I see there is currently no option for this on librespot, but it should not be too hard to add

places:
https://github.com/librespot-org/librespot/blob/a2f832dff171914935f7e1a98a5da3d7c8a0b789/protocol/proto/spirc.proto#L34 this is the command to send for shuffle
https://github.com/librespot-org/librespot/blob/a2f832dff171914935f7e1a98a5da3d7c8a0b789/connect/src/spirc.rs#L70 a new variant should be added for shuffle
https://github.com/librespot-org/librespot/blob/a2f832dff171914935f7e1a98a5da3d7c8a0b789/connect/src/spirc.rs#L324 a new helper function for sending the shuffle command
https://github.com/librespot-org/librespot/blob/a2f832dff171914935f7e1a98a5da3d7c8a0b789/connect/src/spirc.rs#L487 handle the new enum variant

and then a config option in spotifyd has to be added, but we can add that if support is added in librespot

[jackvstrickland]

I have created a PR for the above work in librespot: librespot-org/librespot#666

[robinvd]

Looks good! Im not involved in librespot so i cant merge/approve it. But when that is merged/released we can add it to spotifyd!

[sashahilton00]

Merged. Will be available in the next release, I'm hoping to do that this weekend after a couple of weeks of delay.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.