Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version confusion #911

Closed
georgefst opened this issue Mar 3, 2021 · 8 comments
Closed

Version confusion #911

georgefst opened this issue Mar 3, 2021 · 8 comments
Labels
bug A functionality or parts of a program that do not work as intended

Comments

@georgefst
Copy link

The v0.3.1 binaries report:

$ ./spotifyd -V
spotifyd 0.3.0

And indeed, it seems the version hasn't been bumped.

Presumably it's an accident that the builds were triggered before #909 has been merged.

@georgefst georgefst added the bug A functionality or parts of a program that do not work as intended label Mar 3, 2021
@JojiiOfficial
Copy link
Member

Right. I forgot that the Cargo.toml needs to be updated before a new release should be bumped, my bad. Neither did I see that PR. The release I bumped had another approach, which was to finally fix the ov_callback issue #719. I think we should delete that release and merge #909 with the master branch.

@Spotifyd/maintainers @sirwindfield What do you think?

@mainrs
Copy link
Member

mainrs commented Mar 3, 2021

Hm. Not sure if it is a good idea to delete already published stuff, even if it is wrong, you never know who depends on it once it's online. Maybe editing the release with a [yanked] in the title and just publishing 0.3.2 instead might be a better idea.

@JojiiOfficial
Copy link
Member

Sounds good. Should I make a PR to change the Cargo.toml's version to 0.3.2 or will you change it?

@mainrs
Copy link
Member

mainrs commented Mar 3, 2021

Would be nice if you could do it! :)

@JojiiOfficial
Copy link
Member

Sure!

@tomodachi
Copy link
Contributor

Nice to see This was already reported, just noticed myself :)

Would also be nice if the release was tagged in git. The latest version tagged is 0.3.0

@JojiiOfficial
Copy link
Member

The release v0.3.1 should be tagged, I don't know where you saw something else.

@JojiiOfficial
Copy link
Member

A new version has been created!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A functionality or parts of a program that do not work as intended
Projects
None yet
Development

No branches or pull requests

4 participants