-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version confusion #911
Comments
Right. I forgot that the Cargo.toml needs to be updated before a new release should be bumped, my bad. Neither did I see that PR. The release I bumped had another approach, which was to finally fix the ov_callback issue #719. I think we should delete that release and merge #909 with the master branch. @Spotifyd/maintainers @sirwindfield What do you think? |
Hm. Not sure if it is a good idea to delete already published stuff, even if it is wrong, you never know who depends on it once it's online. Maybe editing the release with a [yanked] in the title and just publishing 0.3.2 instead might be a better idea. |
Sounds good. Should I make a PR to change the Cargo.toml's version to 0.3.2 or will you change it? |
Would be nice if you could do it! :) |
Sure! |
Nice to see This was already reported, just noticed myself :) Would also be nice if the release was tagged in git. The latest version tagged is 0.3.0 |
The release v0.3.1 should be tagged, I don't know where you saw something else. |
A new version has been created! |
The v0.3.1 binaries report:
And indeed, it seems the version hasn't been bumped.
Presumably it's an accident that the builds were triggered before #909 has been merged.
The text was updated successfully, but these errors were encountered: