Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all translation keys have English locale strings available #1199

Closed
MulverineX opened this issue May 23, 2024 · 3 comments
Closed

Ensure all translation keys have English locale strings available #1199

MulverineX opened this issue May 23, 2024 · 3 comments
Labels
*invalid This report is invalid, but thank you anyways!

Comments

@MulverineX
Copy link
Member

No description provided.

@MulverineX MulverineX added this to the Release 4.0.0 milestone May 23, 2024
@NeunEinser
Copy link
Contributor

NeunEinser commented May 23, 2024 •
edited
Loading

I recently changed localizer to return the key when there is no localization found. Perhaps it would be good to wrap it into something, maybe return <key>, so it's easier to spot?

Ideally, we would have some CLI which collects all strings that are passed into localize and sees if they exist, but not sure how feasible that is.

@MulverineX
Copy link
Member Author

That could just be implemented like this #1192

@MulverineX MulverineX closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2024
@MulverineX
Copy link
Member Author

This isn't how this will be implemented

@MulverineX MulverineX removed this from the Release 4.0.0 milestone Jun 20, 2024
@MulverineX MulverineX added *invalid This report is invalid, but thank you anyways! and removed /locales labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
*invalid This report is invalid, but thank you anyways!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MulverineX @NeunEinser