Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support catch2 3.x #235

Open
hosiet opened this issue Jul 12, 2024 · 2 comments
Open

Please support catch2 3.x #235

hosiet opened this issue Jul 12, 2024 · 2 comments

Comments

@hosiet
Copy link

hosiet commented Jul 12, 2024

The current source code needs catch2 2.x to do the tests. With catch2 upstream shifting to the development of v3.x series (currently v3.6.0), please consider updating your source code structure to support catch2 3.x.

@aminroosta
Copy link
Collaborator

Hey @hosiet feel free to open a PR against the dev branch.

@hosiet
Copy link
Author

hosiet commented Dec 21, 2024

I have patch for the code and CMakeLists.txt available and I can provide them. However, the main issue is that Hunter only supports Catch 2.x and there is no sign of supporting 3.x on their side.

Please let me know what would be the best way to proceed. I am attaching the patches here in case anyone need them.

Copyright disclaimer: I hereby release all my contributions listed here and below into the public domain. In cases where releasing into the public domain is not allowed, they shall be released under the same license and copyright holder as the sqlite_modern_cpp project.

0001-cmake-Catch-.cmake-Upgrade-to-v3.patch
0002-Migrate-code-to-use-Catch-v3.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants