Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update rcedit.exe to the latest and greatest. #888

Open
tcoserea opened this issue Dec 1, 2016 · 1 comment
Open

Please update rcedit.exe to the latest and greatest. #888

tcoserea opened this issue Dec 1, 2016 · 1 comment
Labels
infrastructure Pull requests related dependencies, tooling or testing that the project needs

Comments

@tcoserea
Copy link

tcoserea commented Dec 1, 2016

Currently https://github.com/Squirrel/Squirrel.Windows/tree/master/src/Update contains a 7 months old rcedit.exe that produces files with VS_VERSION_INFO damaged (mainly \VarFileInfo does not have the length properly setup) . Apparently the issue was fixed by this change electron/rcedit@556a814

For example Update.exe version 1.4.4.0 (sha1: 6945a869b57bb9947cf9e6587b0f1783000c1bd4) has this issue.

Thanks,
T.
@shiftkey shiftkey added the infrastructure Pull requests related dependencies, tooling or testing that the project needs label May 5, 2019
@Thieum
Copy link
Contributor

Thieum commented May 6, 2019

@shiftkey #1150 #542 #488 are all related to an outdated version of rcedit. Maybe we should consolidate this here.

This was referenced May 7, 2019
Closed
Closed
Closed
@Darkproduct Darkproduct mentioned this issue Jul 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Pull requests related dependencies, tooling or testing that the project needs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shiftkey @Thieum @tcoserea