Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockquotes in markdown mode should always wrap/unwrap selected content #70

Open
Franck-Dernoncourt opened this issue May 4, 2021 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers mode - markdown Affects the editor's markdown input mode
Milestone

Comments

@Franck-Dernoncourt
Copy link

Franck-Dernoncourt commented May 4, 2021

Reported on Meta.SE here.

Describe the bug
Lists are removed when quoted when in markdown mode and the blockquote menu button is clicked.

Expected behavior

The content should be wrapped instead of the block type being replaced. In most cases, replacing the block type is beneficial (unordered list -> ordered list), but in the majority of cases that blockquote is used, the user wants to quote the entire selected text as-is.

To Reproduce
Demo:

SE editor list disappears

Desktop (please complete the following information):

  • OS: Windows 7 SP1 x64 Ultimate
  • Browser chrome
@Franck-Dernoncourt Franck-Dernoncourt added the bug Something isn't working label May 4, 2021
@b-kelly
Copy link
Collaborator

b-kelly commented May 4, 2021

Thanks for the report! This is a very similar issue to #69 - they both are caused by the same underlying behavior.

@b-kelly b-kelly added the good first issue Good for newcomers label May 4, 2021
@b-kelly b-kelly added the mode - markdown Affects the editor's markdown input mode label Oct 7, 2021
@b-kelly b-kelly moved this to Todo in Stacks-Editor Apr 20, 2022
@b-kelly b-kelly added this to the Beta 2 milestone Apr 20, 2022
@yellis
Copy link
Contributor

yellis commented Jun 27, 2022

@b-kelly since #69 was resolved, is this now resolved as well?

@b-kelly b-kelly modified the milestones: Beta 2, Beta 3 Jun 27, 2022
@b-kelly
Copy link
Collaborator

b-kelly commented Jun 27, 2022

I may have misspoke. This one actually looks like a "feature" rather than a bug. The list items are considered a block type, therefore adding a different block type (in this case, blockquotes) replaces them.

Thinking on it, I think we want to leave this functionality in place for the most part, as that'll allow e.g. ordered lists to replace unordered lists, but we may want to instead treat blockquote specially. In most cases that I can think of, you'll always want a blockquote to wrap whatever you have highlighted instead of replacing it (as would be the case with headers, etc).

I'll edit the reported issue to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers mode - markdown Affects the editor's markdown input mode
Projects
Status: Todo
Development

No branches or pull requests

3 participants