Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wrapping of .s-progress--label #809

Open
dancormier opened this issue Dec 16, 2021 · 3 comments
Open

Improve wrapping of .s-progress--label #809

dancormier opened this issue Dec 16, 2021 · 3 comments
Labels
bug A reproducible problem with the Stacks code

Comments

@dancormier
Copy link
Contributor

.s-progress--labels that wrap don't affect the height of its' parent. This could be seen as a feature instead of a bug, but it results in some kinda ugly elements.

See also: #807 (review)

@dancormier dancormier added the bug A reproducible problem with the Stacks code label Dec 16, 2021
@ondrejkonec
Copy link

Hi @dancormier

I would like to take care of this. Do you think that you can contact Design team that can tell us how should the component behave if there is not enough space for it?

There is my suggestion:
Snímek obrazovky 2022-09-30 v 10 26 14
Snímek obrazovky 2022-09-30 v 10 27 51

This is not ideal, but at least it is not broken. Those who create pages with these elements should consider the content and shorten it as needed. But if by chance there is content where it can't be displayed well, at least it won't look like an error.

What do you think?

@dancormier
Copy link
Contributor Author

Hi @ondrejkonec and thanks for the suggestion! This is a design issue so I'm not the one to make the call, but I'd love to change these elements to have flexible height instead of overflowing awkwardly or truncating the text. I believe that would be a more accessible solution since it would avoid loss of content.

At the moment, this is a lower-priority item for our design team so I can't promise we'll address it soon, but having this feedback is valuable!

@ondrejkonec
Copy link

Thanks for reply @dancormier and for more information.

That sounds reasonable! If you have design for this and if you feel that I can rebuild this component, please, feel free to write here and I will take care about implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A reproducible problem with the Stacks code
Projects
None yet
Development

No branches or pull requests

2 participants