Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure conditional hover/focus classes override conditional dark mode classes #815

Open
dancormier opened this issue Dec 22, 2021 · 0 comments
Labels
bug A reproducible problem with the Stacks code dark-mode A problem that only appears in dark mode

Comments

@dancormier
Copy link
Contributor

Current behavior: When an element has a conditional dark mode class and a conditional hover or focus class, the dark mode styling overrides the hover style.

Desired behavior: Hover/focus styling should apply over dark mode styling when hovering.

This was prompted by an issue encountered with this markup:

<button id="js-dismiss-articles-btn" class="s-btn fc-black-200 bg-black-600 bc-black-300 h:bg-black-700 d:bg-black-900" type="submit">*</button>
@dancormier dancormier added bug A reproducible problem with the Stacks code dark-mode A problem that only appears in dark mode labels Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A reproducible problem with the Stacks code dark-mode A problem that only appears in dark mode
Projects
None yet
Development

No branches or pull requests

1 participant