st2chatops smoke tests fail when HUBOT_LOG_LEVEL=info

[cognifloyd]

I have this st2chatops config:

st2chatops_hubot_adapter: slack
st2chatops_config:
  HUBOT_SLACK_TOKEN: "{{ theatro_vault_slack_bot_token }}"
  HUBOT_LOG_LEVEL: info

This forces the st2chatops smoketest to fail despite

ansible-st2/roles/st2smoketests/tasks/st2chatops.yml

Lines 4 to 8 in 136a41e

	shell: timeout 10 bash -c '(sleep 5; echo exit ) | bin/hubot'
	args:
	chdir: /opt/stackstorm/chatops/
	environment:
	HUBOT_LOG_LEVEL: debug

This is because bin/hubot overwrites any variables that are already in the environment:

. $HERE/st2chatops.env

https://github.com/StackStorm/st2chatops/blob/9066a1fed83615fa13b19985c546e9621b612cc0/bin/hubot#L15

[arm4b]

This sounds like st2chatops issue because you can repeat the same manually with CLI.
Can you please report issue in https://github.com/StackStorm/st2chatops/ instead?

[arm4b]

And the fix could be is to handle ENV var this way https://github.com/StackStorm/st2chatops/blob/9066a1fed83615fa13b19985c546e9621b612cc0/st2chatops.env#L1 in st2chatops.env

[cognifloyd]

Hmm. Is this another manifestation of StackStorm/st2chatops#50? Or is it just a related but different issue? StackStorm/st2chatops#50 is about where/how to store the hubot config options, this is about overriding those options from the command line. The fix is very similar for either.

[arm4b]

Yes, exactly.
This sounds like related to StackStorm/st2chatops#50.