CI build reports success on failed tests

[arm4b]

See https://github.com/StackStorm/st2-docker/actions/runs/3189178778/jobs/5202693378#step:5:20
where the BATS tests failed, but for some reason, the non-zero exit code is lost somewhere in between.

This is a bug and help wanted to fix it.

[mamercad]

This is ... interesting (added echo $?) right afterwards:

<snip>
sleep 60
docker-compose -f tests/st2tests.yaml up
echo $?

[mamercad]

So, I think what's happening is that we need to somehow push the exit code from the bats stuff outwards to docker-compose (the caller).

[arm4b]

So sounds like docker-compose up job is to start the containers which it does successfully, and it doesn't care about the exit codes.

[mamercad]

Yeah ... fiddling with --abort-on-container-exit --exit-code-from st2test-tools ...

[mamercad]

Also, I noticed I missed making the jobs dependent:

  docker-compose-up:
    runs-on: ubuntu-latest
    needs: [docker-compose-lint]

The "needs" directive, i.e., if linting fails, don't bother doing what's next.

[arm4b]

--exit-code-from
Good find!

[mamercad]

--exit-code-from Good find!

Hehe, I'm not sure I'm fond of docker-compose to be honest:

Aborting on container exit...
0

Presumably that's from --abort-on-container-exit; trying just --exit-code-from st2test-tools.

[mamercad]

This is quite painful:

st2test_1        | ln: failed to create symbolic link '/sbin/bats': File exists
tests_st2test-tools_1 exited with code 0