fix RouterService clearStackAndShow #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilledStacks
previously approved these changes
May 16, 2023
|
@bilaldbank update the pubspec constraints and push then this should auto merge when it passes flutter analyze |
auto-merge was automatically disabled
May 17, 2023 06:43
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
May 19, 2023 10:14
Head branch was pushed to by a user without write access
|
@FilledStacks formatting issues 😅 |
bilaldbank
force-pushed
the
fix/router_service_clear_stack_and_show
branch
from
f9cff8e
to
15bac1d
Compare
FilledStacks
pushed a commit
that referenced
this pull request
May 26, 2023
## [1.0.4](v1.0.3...v1.0.4) (2023-05-26) ### Bug Fixes * RouterService clearStackAndShow ([#18](#18)) ([a5b775d](a5b775d))
|
🎉 This PR is included in version 1.0.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
clearStackAndShowmethod inRouterServicewhich currently pushes the route on top without clearing the current stack