-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix RouterService clearStackAndShow #18
fix RouterService clearStackAndShow #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I throught this would push the singleRoute only onto the stack and wouldn't need a clear.
@bilaldbank update the pubspec constraints and push then this should auto merge when it passes flutter analyze |
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Head branch was pushed to by a user without write access
@FilledStacks formatting issues 😅 |
f9cff8e
to
15bac1d
Compare
## [1.0.4](v1.0.3...v1.0.4) (2023-05-26) ### Bug Fixes * RouterService clearStackAndShow ([#18](#18)) ([a5b775d](a5b775d))
🎉 This PR is included in version 1.0.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This PR fixes
clearStackAndShow
method inRouterService
which currently pushes the route on top without clearing the current stack