Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mutate bottom sheet and dialog builders #35

Merged
merged 1 commit into from
Mar 26, 2024
Merged

feat: mutate bottom sheet and dialog builders #35

merged 1 commit into from
Mar 26, 2024

Conversation

saileshbro
Copy link
Contributor

Summary

This PR allows mutation of _sheetBuilders and _dialogBuilders allowing to call setCustomSheetBuilders and registerCustomDialogBuilders again.

Use case

This is useful when you have a shared bottom sheets and dialogs in different projects in a monorepo. I have a common package that is being used in two different apps.

Code example for the usage

  static Future<void> initializeDependencies() async {
    await setupLocator();
    common.setupBottomSheetUi();
    setupBottomSheetUi();
    common.setupDialogUi();
    setupDialogUi();
  }

FilledStacks
FilledStacks approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@FilledStacks FilledStacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks safe. Thanks for the PR

@FilledStacks FilledStacks merged commit 711dec5 into Stacked-Org:main Mar 26, 2024
1 check passed
FilledStacks pushed a commit that referenced this pull request Mar 26, 2024
@semantic-release-bot
chore(release): 1.5.0 [skip ci]
936e650 
# [1.5.0](v1.4.0...v1.5.0) (2024-03-26)

### Features

* mutate bottom sheet and dialog builders ([#35](#35)) ([711dec5](711dec5))
@FilledStacks
Copy link
Contributor

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilledStacks FilledStacks FilledStacks approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saileshbro @FilledStacks