-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(i18n): update tests for french and spanish #878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mamadoudicko
changed the title
feat: i8n - french - spanish
fix(i18n): update tests for french and spanish
Aug 7, 2023
LOGAF Level 3 - /home/runner/work/quivr/quivr/frontend/lib/config/LocaleConfig/resources.ts
LOGAF Level 3 - /home/runner/work/quivr/quivr/frontend/app/chat/components/ChatsList/hooks/useChatsList.ts
Example: useEffect(() => {
const fetchAllChats = async () => {
try {
const response = await getChats();
setAllChats(response.reverse());
} catch (error) {
console.error(error);
publish({
variant: "danger",
text: t("errorFetching",{ ns : 'chat'})
});
}
};
fetchAllChats();
}, [getChats, setAllChats]); LOGAF Level 3 - /home/runner/work/quivr/quivr/frontend/app/user/components/BrainConsumption.tsx
<svg>
<clipPath id="clip">
<rect x="0" y="0" width="100%" height={`${(1 - brainFilling) * 100}%`} />
</clipPath>
<GiBrain style={{ clipPath: 'url(#clip)' }} />
</svg>
<GiBrain className="w-full h-full fill-green-200 stroke-black stroke-1" /> 🔧🔗🧠 Powered by Code Review GPT |
gozineb
approved these changes
Aug 7, 2023
Well done @B0rrA! |
StanGirard
pushed a commit
that referenced
this pull request
Sep 12, 2023
* add libraries for traslation purposes * Add button and service for language selection * add spanish translation on login page * add spanish translation on upload page * Add spanish translations for explore page * Add translations on user page * Add translations for config page * Add spanish translations on chat page * add translations for brain page * fix GUI and save on local storage * fix (i18n) init and types * fix (i18n): typos * add translation on new brain modal * add translations on metadata * Add translations on home page * fixes types * fix(frontend-tests): use get by id instead of text --------- Co-authored-by: Gustavo Maciel <gustavo_m13@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original PR: #738
Just fixed tests here. Skipped 3. I'll fix them on next friday