feat: add hero and banner section from builder.io #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ching - Added new constants and utility functions for managing Builder section models. - Implemented dynamic content rendering for Hero and Banner sections using Builder. - Refactored Navbar and Footer components to support dynamic content from Builder. - Introduced new HeroCTA and HeroImageWrapper components for improved user engagement. - Updated layout and page components to fetch and render Builder content dynamically. - Enhanced NavBarGlobalBanner to accept customizable text for better localization. - Registered new components with Builder for seamless integration and customization.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Exported titleVariantsConfig and pageTitleVariants for better accessibility. - Introduced AsVariantsConfig for flexible heading element selection. - Created a new PageTitle builder component to support dynamic rendering in Builder. - Registered the new PageTitle component in the Builder integration for seamless usage.
LucasdRossi
requested changes
Jan 22, 2025
src/components/app/heroImageWrapper/heroImageWrapper.builder.tsx
Outdated
Show resolved
Hide resolved
src/components/app/heroImageWrapper/heroImageWrapper.builder.tsx
Outdated
Show resolved
Hide resolved
src/components/app/heroImageWrapper/heroImageWrapper.builder.tsx
Outdated
Show resolved
Hide resolved
src/components/app/heroImageWrapper/heroImageWrapper.builder.tsx
Outdated
Show resolved
Hide resolved
…components in Builder integration
…ntegration - Removed the 'withChildren' wrapper from both components to streamline their usage. - Updated the component registration to enhance attribute handling and improve key management. - Added 'friendlyName' and 'noWrap' properties for better integration with Builder's UI.
…eTitle components in Builder integration - Simplified the component registration for both PageSubTitle and PageTitle by eliminating the 'canHaveChildren' property, enhancing clarity and usability in the Builder environment.
…n HeroCTA component - Updated HeroCTAProps interface to allow optional properties for authenticated and unauthenticated props, enhancing flexibility in component usage.
…ntegration
- Removed unnecessary properties ('as' and 'withoutBalancer') from the Builder component props, streamlining the interface.
- Updated input configuration to require a 'text' property, enhancing clarity and usability in the Builder environment.
- Improved overall component registration for better integration with Builder's UI.
…onents in Builder integration - Eliminated the defaultChildren property from both components to simplify their configuration and enhance usability in the Builder environment.
olavoparno
changed the title
LucasdRossi
requested changes
Jan 29, 2025
Comment on lines
+10
to
+12
| userAttributes: { | ||
| urlPath: pathname, | ||
| }, |
There was a problem hiding this comment.
Shouldn't we use prerender: false here?
Comment on lines
+10
to
+12
| userAttributes: { | ||
| urlPath: pathname, | ||
| }, |
There was a problem hiding this comment.
Shouldn't we use prerender: false here?
Comment on lines
2
to
3
| HERO = 'hero-model', | ||
| BANNER = 'banner', |
There was a problem hiding this comment.
Suggested change
| HERO = 'hero-model', | |
| BANNER = 'banner', | |
| HERO = 'hero-cta', | |
| BANNER = 'global-banner', |
| Builder.registerComponent( | ||
| (props: BuilderPageTitleProps) => ( | ||
| <PageTitle {...props.attributes} key={props.attributes?.key}> | ||
| {props.children} |
There was a problem hiding this comment.
Shouldn't this be props.title?
| name: 'PageTitle', | ||
| friendlyName: 'Page Title', | ||
| noWrap: true, | ||
| inputs: [ |
There was a problem hiding this comment.
I think we should support the variant prop here to
| videoPath: props.videoPath, | ||
| } | ||
|
|
||
| const isAuthenticated = props.builderState?.state?.isAuthenticated |
There was a problem hiding this comment.
This prop is not reliable enough to render authenticated content, we should use our own logic instead, like MaybeAuthenticatedContent or LoginDialogWrapper
Comment on lines
55
to
58
| export interface HeroImageWrapperProps { | ||
| unauthenticatedProps?: HeroImageContentProps | ||
| authenticatedProps?: HeroImageContentProps | ||
| } |
There was a problem hiding this comment.
Is this still necessary?
There was a problem hiding this comment.
not anymore, thanks
| friendlyName: 'Hero Image', | ||
| canHaveChildren: false, | ||
| noWrap: true, | ||
| inputs: [ |
There was a problem hiding this comment.
We should also support a dynamic alt prop here to pass to the image
|
|
||
| export function NavBarGlobalBanner({ | ||
| outsideUSBannerText = 'Actions on Stand With Crypto are only available to users based in the United States.', | ||
| hideBanner = false, |
There was a problem hiding this comment.
Instead of adding this hideBanner prop, can't we check if campaignText is null and don't render the banner?
There was a problem hiding this comment.
this is meant to hide the banner altogether, disregarding if it has campaign or not
| noWrap: true, | ||
| inputs: [ | ||
| { | ||
| name: 'outsideUSBannerText', |
There was a problem hiding this comment.
I don't think we want this prop to be controlled in Builder.io, we should check with Adam if this is necessary
- Refactored HeroBuilder and NavBarGlobalBannerBuilder to accept content prop - Updated layout and page components to pass Builder.io section content - Modified Hero and Banner components to use dynamic content - Updated section model identifiers for better clarity - Simplified component props and rendering logic
…Builder.io - Created separate HeroImage and HeroText Builder.io components - Updated page and layout components to fetch and render distinct hero content - Modified HeroImageContent props to use more generic naming - Added new render components for Hero Image and Text sections - Updated section model identifiers to distinguish between hero image and text
- Removed unused fallback prop from RenderBuilderContent component - Simplified NavBarGlobalBannerBuilder by removing fallback rendering - Cleaned up unnecessary conditional rendering logic
…dling - Added custom fetch options to getSectionContent utility function - Configured request with no-cache, keepalive, and GET method - Enhances Builder.io section content retrieval with more robust network request parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1736
closes #1737
fixes
What changed? Why?
PlanetScale deploy request
Notes to reviewers
How has it been tested?