Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically deploy Firestore rules from git #25

Open
1 task done
Supereg opened this issue Oct 25, 2023 · 2 comments
Open
1 task done

Automatically deploy Firestore rules from git #25

Supereg opened this issue Oct 25, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Supereg
Copy link
Member

Supereg commented Oct 25, 2023

Problem

We configure the Firestore rules within the repository (see firestore.rules file). Currently, this is automatically picked up by the emulator but is not deployed to Firebase itself.

Solution

Use a GitHub Action on a successful PR merge to deploy updated Firestore rules automatically to the cloud. The general Firestore rules documentation page might be helpful. To integrate it into GitHub Actions, we might want to rely on the GitHub Action for Firebase.

Additional context

We might want to consider a future setup, where we have multiple Firestore projects running (e.g. production vs. development).
Further, we should consider referencing the above documentation links in the Template Application.

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@Supereg Supereg added the enhancement New feature or request label Oct 25, 2023
@Supereg
Copy link
Member Author

Supereg commented Nov 5, 2023

We might want to look into StanfordBDHG/.github#39

@PSchmiedmayer
Copy link
Member

@Supereg The changes in StanfordSpezi/SpeziTemplateApplication#54 should showcase all that needs to be done to set this up for our project here.

Happy to setup everything around the services account and surrounding infrastructure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants