Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Node SDK] add fetch instrumentation when it is fixed and working with Node #59

Open
ktrz-sre-is opened this issue Apr 12, 2023 · 2 comments
Open

[Node SDK] add fetch instrumentation when it is fixed and working with Node #59

ktrz-sre-is opened this issue Apr 12, 2023 · 2 comments
Labels
blocked Blocked and unable to make progress node-sdk
Milestone
MVP GA

Comments

@ktrz-sre-is
Copy link
Contributor

related issue open-telemetry/opentelemetry-js#3413
@ktrz-sre-is ktrz-sre-is mentioned this issue Apr 12, 2023
Merged
@sre-is-josebiro sre-is-josebiro added this to the MVP GA milestone May 8, 2023
@mattjohnsonpint-sre-is
Copy link
Contributor

Looks like we're just using node-fetch for now, which is fine - but we will want to instrument native fetch as soon as possible too.

https://github.com/StanzaSystems/stanza-js/blob/main/packages/node/src/fetchImplementation.ts

@ktrz-sre-is
Copy link
Contributor Author

This is still blocked by the OTel issue. CC: @sre-is-josebiro

@sre-is-marcelo sre-is-marcelo added the blocked Blocked and unable to make progress label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Blocked and unable to make progress node-sdk
Projects
None yet
Milestone
MVP GA
Development

No branches or pull requests
4 participants
@sre-is-josebiro @ktrz-sre-is @mattjohnsonpint-sre-is @sre-is-marcelo