Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it realy tested on IE8? #223

Closed
mort3za opened this issue Mar 3, 2019 · 5 comments
Closed

Is it realy tested on IE8? #223

mort3za opened this issue Mar 3, 2019 · 5 comments
Assignees

Comments

@mort3za
Copy link

mort3za commented Mar 3, 2019

In the source code I see new WeakMap() which is only available in IE11. Also I've tested it on IE9 and it has an error for using WeakMap.

@alshakero
Copy link
Collaborator

You're right. It would be appreciated if you could PR to fix the README.

@alshakero alshakero self-assigned this Mar 3, 2019
@mort3za
Copy link
Author

mort3za commented Mar 6, 2019

I recommend you to generate an es5 version of the library beside current build If you want to keep es6 version (and it's a good idea because it's faster and smaller).

@alshakero
Copy link
Collaborator

alshakero commented Mar 6, 2019

Sorry but we're not willing to maintain support for IE8. We only support IE10+ for the meantime.

@mort3za
Copy link
Author

mort3za commented Mar 6, 2019

IE10+ means included IE10, right?
IE10 don't understand WeakMap :)

Personally I have no problem with or without IE support, because I have included babel-polyfill, But I think supporting more browers leads to fewer hassles for developers.

@warpech
Copy link
Collaborator

warpech commented Mar 25, 2019

We will fix the readme to say that only IE11 is supported directly. Older browsers can by supported using a polyfill, however WeakMap is not completely polyfillable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants