Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonpatch.compare should not modify the mirror object #52

Closed
alex3683 opened this issue Jul 28, 2014 · 3 comments
Closed

jsonpatch.compare should not modify the mirror object #52

alex3683 opened this issue Jul 28, 2014 · 3 comments

Comments

@alex3683
Copy link
Contributor

I totally understand that jsonpatch.generate modifies the objects it watches to always only detect most recent changes (as discussed in #18 ) of an object. In my opinion this should not be the case for jsonpatch.compare as I explicitly use this method with objects that are not under control of jsonpatch observers. Thus modification of these objects should be under my control as well.

@warpech
Copy link
Collaborator

warpech commented Nov 26, 2014

Pull request with improved performance was merged to master branch. You can use it now or wait for numbered release 0.5.0 (should be soon)

@alex3683
Copy link
Contributor Author

Thanks! Will stick with our fork until the official release.

@warpech
Copy link
Collaborator

warpech commented Nov 28, 2014

Released in 0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants