Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single sign out support #46

Open
dentarg opened this issue Mar 15, 2016 · 6 comments
Open

Single sign out support #46

dentarg opened this issue Mar 15, 2016 · 6 comments
Labels

Comments

@dentarg
Copy link
Member

dentarg commented Mar 15, 2016

See atmos/warden-github#46

We should probably use https://github.com/atmos/sinatra_auth_github which has support for that

@dentarg
Copy link
Member Author

dentarg commented Dec 15, 2016

Related: if you sign in and after that update your membership (join/leave Starkast org on GitHub), we don't catch that

@dentarg
Copy link
Member Author

dentarg commented Mar 14, 2018

sinatra_auth_github has been archived, so maybe not the best of options

warden-github has not been archived, maybe an option (need to build a little bit more ourselves)

https://github.com/atmos/warden-github#single-sign-out

@dentarg
Copy link
Member Author

dentarg commented Apr 18, 2018

https://github.com/atmos/warden-github#single-sign-out

I don't this works for oauth apps you create yourself, sounds like it is only something GitHub can use:

OAuth applications owned by the GitHub organization are sent an extra browser parameter to ensure that the user remains logged in to github.com.

Yes, see: atmos/warden-github#51

@dentarg
Copy link
Member Author

dentarg commented Apr 18, 2018

Maybe the new GitHub Apps can dome something like it, haven't checked.

@dentarg
Copy link
Member Author

dentarg commented Oct 30, 2019

warden-github has not been archived

It is archived now 😢

@dentarg
Copy link
Member Author

dentarg commented Oct 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant