Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/del_player does not handle claims. #107

Open
GermaniumSystem opened this issue Jul 1, 2017 · 1 comment
Open

/del_player does not handle claims. #107

GermaniumSystem opened this issue Jul 1, 2017 · 1 comment
Labels

Comments

@GermaniumSystem
Copy link
Contributor

When a player is deleted with "/del_player" any claims that player had will be owned by a UUID with no name. This becomes especially problematic for player ships, as any new player with the deleted player's name will have their ship claimed under the deleted player's UUID.

We need to handle claims when deleting a player, but how should it be implemented? Ship claims can be easily deleted, but planets are a different story. If the old player had claimed important planets, simply un-claiming them could get messy. Maybe we could transfer ownership to a builder (if one exists) or have an optional argument to specify a player that should be given ownership?

@rubellyte
Copy link
Member

rubellyte commented Jul 1, 2017

This is really an issue with every plugin that stores data per-player, since only the base data is actually saved on the player object. It might be worth adding some sort of on_delete_player method for plugins to hook into to deal with this.

@rubellyte rubellyte added the bug label Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants