Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve image inheritance strategy #48

Closed
brendangadd opened this issue May 26, 2020 · 1 comment
Closed

Improve image inheritance strategy #48

brendangadd opened this issue May 26, 2020 · 1 comment

Comments

@brendangadd
Copy link
Contributor

We want to benefit as much as possible from upstream fixes in Jupyter's core docker stacks, but also be able to inherit from our own base image so we can fix our own layers in a minimal number of locations. Right now, our base image inherits from deep in the core docker stack tree.

I'm wondering if we should use a mixin approach so we can benefit from upstream fixes to the whole tree without pushing our base image to a leaf node. This will allow us to extend from multiple locations in the core tree while preserving common config of our own.

@sylus
Copy link
Member

sylus commented Aug 17, 2020

I think this issue was closed with the recent merge?

Feel free to re-open but this looks solved to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants