-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Python and R package testing #536
Comments
We recently had an issue with JupyerLab-Git extension not working with Python 3.11. So in addition to having package import tests, we might also want JupyerLab extension tests. Reference to issue (h/t @Souheil-Yazji): |
We may also want to have some example notebooks, which are run during testing, to ensure our "core offerings" just work. Some example SASPy Notebooks can be found here: Or maybe just take some of the core commands from some example notebooks, and add them to our test suite, but then make sure they fail when they should fail and pass when they should pass. |
The package testing we use does not work well. Code is here: https://github.com/StatCan/aaw-kubeflow-containers/blob/master/tests/general/test_packages.py
Example issues with the current test suite:
torch
was not working for quite a while buttest_packages.py
was unable to catch this. Unable to import torch on pytorch image. #514pyyaml
is imported withimport yaml
andpillow
is imported withimport pil
.The exclusion list is growing:
The text was updated successfully, but these errors were encountered: