Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline Removal - Testing #1472

Closed
22 of 23 tasks
wg102 opened this issue Dec 14, 2022 · 11 comments
Closed
22 of 23 tasks

Pipeline Removal - Testing #1472

wg102 opened this issue Dec 14, 2022 · 11 comments
Assignees
Labels
area/engineering Requires attention from engineering: focus on foundational components or platform DevOps kind/feature New feature or request size/M 2-3 days

Comments

@wg102
Copy link
Contributor

wg102 commented Dec 14, 2022

Following the removal of Pipelines in #1449
We now need to thoroughly test it.

These are split with categories.

  1. Creating notebooks
  • Create anotebook ubuntu
  • Create a notebook Rstudio
  • Create a sas notebook
  • Create a Jupyterlab notebook
  • Create anotebook ubuntu Pro-B
  • Create a notebook Rstudio Pro-B
  • Create a sas notebook Pro-B
  • Create a Jupyterlab notebook Pro-B
  1. Creating pipeline
  • Try to create a pipeline inside of a notebook expected result: fail
  • Verify that no pipeline related resources were created in the notebook creation or the pipeline step
  1. Managing contributors
  • Add a contributor
  • Remove a contributor
  1. Managing data
  • Add a volume
  • Mount a data-volume
  • Minio
  1. Miscellaneous
  • Installing a new package
    • Ubuntu
    • Rstudio
    • Sas
    • Jupyterlab
  • Verify if we have a PodDefault setup to allow sdk access from Notebooks

Argo Workflow Tests

Removed in favor or #1497
Might want to create a ticket on documentation for this. The how to. And will need to update the documentation OUT for pipelines

  • verify that users are able to submit workflows to argo workflow server via kubectl / argo / web ui
  • verify that users are able to list workflows that have been submitted via kubectl / argo /web ui
  • [✗] verify that users are able to delete workflows
@wg102 wg102 mentioned this issue Dec 14, 2022
5 tasks
@wg102 wg102 added the size/M 2-3 days label Dec 14, 2022
@chuckbelisle chuckbelisle added kind/feature New feature or request area/engineering Requires attention from engineering: focus on foundational components or platform DevOps labels Dec 14, 2022
@wg102
Copy link
Contributor Author

wg102 commented Dec 28, 2022

EDIT: issue created #1498

There is an error in the console log as soon as you go to the Notebooks page

image

@wg102
Copy link
Contributor Author

wg102 commented Jan 4, 2023

The error above might be coming from the dashboard, since it still looks for "Recent Pipelines" and such

@wg102
Copy link
Contributor Author

wg102 commented Jan 5, 2023

Related to part 2, Tested in jupyterlap The pipeline did fail to create
image

The missing token.

Part 2, no resource created: this was as expected, no experiment resources were created

@wg102
Copy link
Contributor Author

wg102 commented Jan 6, 2023

Point 3. add a volume.

EDIT: Issue created StatCan/jupyter-apis#196

I am not sure if this is supposed to be like this, but the only option is to add a New volume. No èxisting.
The "Attach an existing volume" is grayed out.
image

Addendum:
I think this is actually related to how the UI works. The type, despite being a DROPDOWN. Is just showing the default empty volume created.
image
One needs to delete the default workspace create to be able to attach the volume directly.
image

@wg102
Copy link
Contributor Author

wg102 commented Jan 6, 2023

Solved: notebook was deleted.

Unsure if this is related, but error message when clicking on the python
image
Then imediatly this one
image

@wg102
Copy link
Contributor Author

wg102 commented Jan 6, 2023

Part 5.
Testing package install.
I am using the following command to test the download. pip3 install torch torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/cu117

Edit:
I am using pip uninstall wheel
than
pip install --index-url https://pypi.python.org/simple wheel

@wg102
Copy link
Contributor Author

wg102 commented Jan 6, 2023

Miscellanous: using the following command in a terminal pip3 list I see a package related to pipeline. Possibly 4 (if all the ones with kfp are stranding for kubeflow-pipline
image

@wg102
Copy link
Contributor Author

wg102 commented Jan 10, 2023

Testing argoflow:
I would try and submit a hello world workflow to verify that everything worked as expected (see https://github.com/argoproj/argo-workflows/blob/master/examples/hello-world.yaml for example) - you can just kubectl apply the yaml. Note you might need to modify some stuff to work on the AAW (e.g. proxy through artifactory, image pull secrets, etc.), but otherwise a simple hello world should work out of the box

@wg102
Copy link
Contributor Author

wg102 commented Jan 10, 2023

For the workflow test, the code had to be slightly modified,
we removed the generated name and use name directly

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  name: hello-world
  labels:
    workflows.argoproj.io/archive-strategy: "false"
  annotations:
    workflows.argoproj.io/description: |
      This is a simple hello world example.
      You can also run it in Python: https://couler-proj.github.io/couler/examples/#hello-world
spec:
  entrypoint: whalesay
  templates:
  - name: whalesay
    container:
      image: docker/whalesay:latest
      command: [cowsay]
      args: ["hello world"]

@wg102
Copy link
Contributor Author

wg102 commented Jan 10, 2023

Unable to delete the workflow through kubectl
This is done in the dev environment. Directly in a jupyter notebook terminal
image

@wg102
Copy link
Contributor Author

wg102 commented Jan 11, 2023

Closing this ticket as complete since the dev testing is done.

New issues have been created for anything found that was out of scope.

@wg102 wg102 closed this as completed Jan 11, 2023
@wg102 wg102 mentioned this issue Jan 11, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engineering Requires attention from engineering: focus on foundational components or platform DevOps kind/feature New feature or request size/M 2-3 days
Projects
None yet
Development

No branches or pull requests

2 participants