Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update R-Shiny docs #186

Closed
chuckbelisle opened this issue Jul 31, 2020 · 2 comments
Closed

Update R-Shiny docs #186

chuckbelisle opened this issue Jul 31, 2020 · 2 comments
Assignees
Labels
kind/docs Improvements or additions to documentation priority/backlog size/S ~1 day

Comments

@chuckbelisle
Copy link
Contributor

Tracking changes to the documentation for the R-Shiny dashboard

@chuckbelisle chuckbelisle added kind/docs Improvements or additions to documentation size/S ~1 day priority/backlog labels Jul 31, 2020
@blairdrummond
Copy link
Contributor

CC @ca-scribner

We should remove the reliance on shiny/PACKAGES that we currently use and use a dependencies.R file in the dashboard folder. Example. Then we can remove reference to the shiny repo in our documentation. (This might also simplify the testing process)

Then we should lay out the PR process in more detail; i.e.

  1. Fork the repo https://github.com/StatCan/R-dashboards
  2. Add a new folder with your dashboard
  3. Make sure that the folder has ui.R, server.R, and dependencies.R (provide an example and use install.packages(package_name))
  4. Submit the Pull Request, and Tag the DAaaS team.

@Souheil-Yazji
Copy link
Contributor

Shiny dash feat removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs Improvements or additions to documentation priority/backlog size/S ~1 day
Projects
None yet
Development

No branches or pull requests

4 participants