Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Trino Secrets #980

Closed
wg102 opened this issue Apr 5, 2022 · 4 comments
Closed

Implement Trino Secrets #980

wg102 opened this issue Apr 5, 2022 · 4 comments
Assignees
Labels

Comments

@wg102
Copy link
Contributor

wg102 commented Apr 5, 2022

Trino should additionally authenticate with a secret at the very least
Remove the hardcoded passwords from the trino and use secrets instead.

Including the necessary things for local testing to work.

This was referenced Apr 5, 2022
@wg102
Copy link
Contributor Author

wg102 commented Apr 13, 2022

Tasks to do:

  • Figure out the changed needed to add the secret to the catalog
  • For local testing, need to add something in the Makefile
  • For dev testing (or prod) need to add a secret in the terraform repo

Sorry, something went wrong.

@wg102
Copy link
Contributor Author

wg102 commented Apr 14, 2022

Terraform secret PR added on Gitlab on 14-04-2022

@wg102
Copy link
Contributor Author

wg102 commented Apr 14, 2022

A similar PR will be needed for prod as well.

@wg102 wg102 closed this as completed Apr 19, 2022
@wg102
Copy link
Contributor Author

wg102 commented Apr 19, 2022

The way it works is that locally, we create secrets by running make secrets.
On dev the secrets are already there since we added a PR to github. (Not sure if this got merged yet # 103). Prod will be same as dev, but the secrets have not been created yet. The values.yaml implements a env variable using a reference to the secret. and that env var is used in the code. That is how we will now use secrets in trino and removed the hardcoded password and username

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant