Skip to content

Commit

Permalink
Merge pull request #115 from StatCan/remove-kubecost
Browse files Browse the repository at this point in the history
Remove kubecost table and fix i18n
  • Loading branch information
rohank07 authored Mar 11, 2022
2 parents e1afc90 + c452704 commit 3f6d99b
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

<!-- Volume Name Input -->
<mat-form-field appearance="outline" id="name">
<mat-label>Name</mat-label>
<mat-label>{{ 'common.name' | translate }}</mat-label>
<input
matInput
formControlName="name"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,16 @@
(actionsEmitter)="reactVolumeToAction($event)"
></lib-resource-table>

<lib-resource-table *ngIf="this.getCostStatus() == true; else error"
<!-- todo: Fix kubecost -->
<!-- <lib-resource-table *ngIf="this.getCostStatus() == true; else error"
[config]="costConfig"
[data]="processedCostData"
[trackByFn]="costTrackByFn"
></lib-resource-table>
></lib-resource-table> -->

<div class="center-flex ">
<p>{{ 'jupyter.costTable.kubeCostError' | translate }}</p>
</div>

<ng-template #error>
<div *ngIf="this.getCostStatus() == false" class="center-flex costerror">
Expand Down
3 changes: 2 additions & 1 deletion frontend/jupyter/src/assets/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@
"gpus": "GPUs",
"storage": "Storage",
"total": "Total",
"errMessage": "Failed to retrieve cost information"
"errMessage": "Failed to retrieve cost information",
"kubeCostError": "Cost information is temporarily unavailable"
}
},
"common": {
Expand Down
3 changes: 2 additions & 1 deletion frontend/jupyter/src/assets/i18n/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@
"gpus": "GPUs",
"storage": "Stockage",
"total": "Total",
"errMessage": "Échec de la récupération des informations des coûts."
"errMessage": "Échec de la récupération des informations des coûts.",
"kubeCostError": "Les informations sur les coûts sont temporairement non disponible"
}
},
"common": {
Expand Down

0 comments on commit 3f6d99b

Please sign in to comment.