feat(response): Update error responses to HTTP 200 because the web in…

…terface will not show the user the error on a 500 response
StatCan · Aug 13, 2020 · 73fafd8 · 73fafd8
1 parent 4370e46
commit 73fafd8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/Dockerfile b/Dockerfile
@@ -33,4 +33,5 @@ RUN CGO_ENABLED=0 go install .
 FROM scratch
 COPY --from=frontend /app/dist/out/default /static/
 COPY --from=backend /go/bin/jupyter-apis /jupyter-apis
+EXPOSE 5000
 ENTRYPOINT [ "/jupyter-apis" ]
diff --git a/httputils.go b/httputils.go
@@ -29,7 +29,7 @@ func (s *server) error(w http.ResponseWriter, r *http.Request, err error) {
 	log.Printf("returning error response: %v", err)
 
 	w.Header().Add("Content-Type", "application/json")
-	w.WriteHeader(http.StatusInternalServerError)
+	w.WriteHeader(http.StatusOK)
 	encoder := json.NewEncoder(w)
 	werr := encoder.Encode(APIResponse{
 		Success: false,