feat(vault config): set up access for users to access KVs through OIDC. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachomedia
suggested changes
May 7, 2020
justbert
changed the title
added 5 commits
May 9, 2020 11:49
Started to build out the code to be more easily extended and tested.
zachomedia
suggested changes
May 12, 2020
There was a problem hiding this comment.
@justbert Thanks for the updates to this, I took an initial look through and left some comments beind - but doesn't seem like anyhting major. Great work!
justbert
changed the title
added 4 commits
May 20, 2020 16:35
Signed-off-by: justin.bertrand <justin.bertrand@canada.ca>
zachomedia
suggested changes
Jun 2, 2020
added 3 commits
June 2, 2020 12:13
Signed-off-by: Justin Bertrand <justin.bertrand@canada.ca>
Signed-off-by: Justin Bertrand <justin.bertrand@canada.ca>
…w them access to vault. Signed-off-by: Justin Bertrand <justin.bertrand@canada.ca>
|
Goes with PR#15. |
zachomedia
approved these changes
Jun 2, 2020
|
@justbert Can you rebase this against the latest master so that it removes the merge conflict? |
…ccess # Conflicts: # defaults.go
|
@zachomedia Done! |
|
@zachomedia Is this ready to be merged? Do we need to wait for the evening? |
|
@justbert I wanted to wait until you were available in case there are issues. Maybe this afternoon we can do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, so here's my PR for daaas/#23.
It adds the ability to create or update the entity that links to an entity-alias.