Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubeflow to v1.2 #11

Closed
brendangadd opened this issue Jul 29, 2020 · 5 comments · Fixed by StatCan/aaw-kubeflow-manifests#65 or StatCan/aaw-kubeflow-manifests#67
Closed
Assignees
Labels
area/engineering Requires attention from engineering: focus on foundational components or platform DevOps kind/task priority/soon size/M 2-3 days

Comments

@brendangadd
Copy link

Move from current v1.0 to v1.1.

@sylus
Copy link
Member

sylus commented Aug 10, 2020

The current status is here:

https://github.com/orgs/kubeflow/projects/36

@brendangadd brendangadd added area/engineering Requires attention from engineering: focus on foundational components or platform DevOps kind/task priority/soon size/M 2-3 days labels Aug 21, 2020
@sylus
Copy link
Member

sylus commented Nov 24, 2020

@sylus
Copy link
Member

sylus commented Nov 24, 2020

Number 1

kustomize/profiles/base/kustomization.yaml

- name: gcr.io/kubeflow-images-public/kfam

  -newName: k8scc01covidacr.azurecr.io/kfam
  -newTag: latest

  +newName: gcr.io/kubeflow-images-public/kfam
  +newTag: vmaster-gf3e09203

Number 2

kustomize/profiles/base/deployment.yaml

      imagePullSecrets:
      - name: k8scc01covidacr-registry-connection

Number 3

kustomize/profiles/base_v3/kustomization.yaml

  -newName: k8scc01covidacr.azurecr.io/kfam
  -newTag: latest

  +newName: gcr.io/kubeflow-images-public/kfam
  +newTag: vmaster-gf3e09203

Number 4

kustomize/profiles/base_v3/deployment_patch.yaml

      imagePullSecrets:
      - name: k8scc01covidacr-registry-connection

Number 5

kustomize/pipelines-ui/base/deployment.yaml

        - name: ARGO_ARCHIVE_LOGS
          value: "true"
        - name: ARGO_ARCHIVE_ARTIFACTORY
          value: minio
        - name: ARGO_ARCHIVE_BUCKETNAME
          value: mlpipeline
        - name: ARGO_ARCHIVE_PREFIX
          value: artifacts

Number 6

kustomize/oidc-authservice/base/statefulset.yaml

        - image: k8scc01covidacr.azurecr.io/oidc-authservice:latest
        + image: gcr.io/arrikto/kubeflow/oidc-authservice:6ac9400

        -value: preferred_username
        +value: email

        - value: "profile email"
        - value: "profile email groups"

      imagePullSecrets:
        - name: k8scc01covidacr-registry-connection

Number 6

kustomize/oidc-authservice/base/envoy-filter.yaml

- istio: ingressgateway-kubeflow
+ istio: ingressgateway

Number 7

kustomize/notebook-controller/base/deployment.yaml

        env:
          - name: USE_ISTIO
            value: "false"
          - name: POD_LABELS
            value: $(POD_LABELS)
          - name: ENABLE_CULLING
            value: "true"
          - name: IDLE_TIME
            value: "1440"
          - name: CULLING_CHECK_PERIOD
            value: "1"

Number 8

kustomize/minio/base/persistent-volume-claim.yaml

      - storage: 200Gi
      + storage: 20Gi

Number 9

kustomize/knative-install/base/config-map.yaml

- gateway.kubeflow.kubeflow-gateway: "istio-ingressgateway.istio-system.svc.cluster.local"
+ gateway.kubeflow.kubeflow-gateway: "istio-ingressgateway-kubeflow.istio-system.svc.cluster.local"

Number 10

Investigate the move into AWS and restore custom config

kustomize/jupyter-web-app/base/config-map.yaml -> kustomize/jupyter-web-app/overlays/aws/config-map.yaml <-- lots of our work is here

Number 11

kustomize/jupyter-web-app/base/params.env

KUBECOST_URL=http://kubecost-cost-analyzer.kubecost.svc.cluster.local:9090

Number 12

kustomize/jupyter-web-app/base/kustomization.yaml

- name: gcr.io/kubeflow-images-public/jupyter-web-app
  -newName: k8scc01covidacr.azurecr.io/jupyter-apis
  -newTag: f938db9495db669b280529482c82ff518effaec5
  +newName: gcr.io/kubeflow-images-public/jupyter-web-app
  +newTag: vmaster-gd9be4b9e

Number 13

kustomize/jupyter-web-app/base/deployment.yaml

  - replicas: 3
  + replicas: 1

      - env:
        - name: ROK_SECRET_NAME
          valueFrom:
            configMapKeyRef:
              name: parameters
              key: ROK_SECRET_NAME
        - name: UI
          valueFrom:
            configMapKeyRef:
              name: parameters
              key: UI
        - name: USERID_HEADER
          value: $(userid-header)
        - name: USERID_PREFIX
          value: $(userid-prefix)
        - name: KUBECOST_URL
          valueFrom:
            configMapKeyRef:
              name: parameters
              key: KUBECOST_URL
        image: gcr.io/kubeflow-images-public/jupyter-web-app:v0.5.0
        imagePullPolicy: $(policy)

      volumes:
      - configMap:
          name: config
          name: jupyter-web-app-config
        name: config-volume
      imagePullSecrets:
      - name: k8scc01covidacr-registry-connection

Number 14

kustomize/jupyter-web-app/base/cluster-role.yaml

add watches back

Number 15

kustomize/centraldashboard/base/kustomization.yaml

  - newName: k8scc01covidacr.azurecr.io/kubeflow/centraldashboard
  - newTag: cb2964cb4f5562b60c97f89b7ee79e4cb179216a
  + newName: gcr.io/kubeflow-images-public/centraldashboard
  + newTag: v1.1.0-g35d7484a

Number 16

kustomize/centraldashboard/base/deployment.yaml

        env:
        - name: USERID_HEADER
          value: $(userid-header)
        - name: USERID_PREFIX
          value: $(userid-prefix)
        - name: PROFILES_KFAM_SERVICE_HOST
          value: profiles-kfam.kubeflow
      serviceAccountName: centraldashboard
      imagePullSecrets:
      - name: k8scc01covidacr-registry-connection

Number 17

look at bootstrap service as last time caused us issues

Number 18

kustomize/argo/base/service.yaml

  - type: ClusterIP     
  + type: NodePort

Number 19

kustomize/argo/base/config-map.yaml

        },
        archiveLogs: true

Number 20

kustomize/argo/base/cluster-role.yaml

delete on pods

@sylus
Copy link
Member

sylus commented Nov 24, 2020

Think this is ready for Thursday, and then next week can do 1.2 with this list of things to watch above ^

@sylus sylus changed the title Upgrade to v1.1 Update Kubeflow to v1.1 Nov 25, 2020
@sylus sylus reopened this Nov 27, 2020
@sylus
Copy link
Member

sylus commented Nov 27, 2020

I have opened an upstream issue with this:

kubeflow#5440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engineering Requires attention from engineering: focus on foundational components or platform DevOps kind/task priority/soon size/M 2-3 days
Projects
None yet
4 participants