Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if skycultures asterism_names.eng.fab is nothing, the list in the search window is not cleared. #3853

Closed
3domennotry opened this issue Aug 14, 2024 · 5 comments
Closed

if skycultures asterism_names.eng.fab is nothing, the list in the search window is not cleared. #3853

3domennotry opened this issue Aug 14, 2024 · 5 comments
Assignees
@alex-w
Labels
bug Something likely wrong in the code purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes state: confirmed A developer can reproduce the issue
Milestone
24.3

Comments

@3domennotry
Copy link

Expected Behaviour

Asterism list in the search window is cleared.

Actual Behaviour

Asterism list in the search window is not cleared.

Steps to reproduce

  1. Show "Sky and viewing options" window.

  2. Show "Sky Culture".

  3. Select the Sky Culture with asterisms. ex. "Modern"
    20240815_1-1

  4. Close Search window.

  5. Select the Sky Culture without asterisms. ex. "Maya"

  6. Show Search window.
    20240815_1-2

Several skycultures folder not inluded "asterism_names.eng.fab".
If "asterism_names.eng.fab" is nothing, Bugs will happen.

Dummy(empty) file is needed.

System

  • Stellarium version: stellarium-24.2-qt5-win32.exe

    • stellarium-24.2-98544be-patch-qt5-win32.exe
    • stellarium-24.2-623f996-patch-qt5-win32.exe

  • Operating system: Win7 32bit

(Sorry, I can not speak English very well.)

thank you.
@alex-w alex-w added the bug Something likely wrong in the code label Aug 14, 2024
@alex-w alex-w added this to the 24.3 milestone Aug 14, 2024
@alex-w alex-w self-assigned this Aug 14, 2024
@alex-w alex-w added the state: confirmed A developer can reproduce the issue label Aug 15, 2024
@github-actions GitHub Actions
Copy link

Hello @3domennotry!

OK, developers can reproduce the issue. Thanks for the report!

@alex-w alex-w closed this as completed in f616daa Aug 20, 2024
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Aug 25, 2024
@github-actions GitHub Actions
Copy link

Hello @3domennotry!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w
Copy link
Member

alex-w commented Aug 25, 2024

Please use full package for testing sky cultures

@3domennotry
Copy link
Author

I have confirmed that this bug has been fixed.
Thank you very much.

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Sep 22, 2024
@github-actions GitHub Actions
Copy link

Hello @3domennotry!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

@alex-w alex-w added the purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-w alex-w

Labels
bug Something likely wrong in the code purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes state: confirmed A developer can reproduce the issue
Milestone
24.3
Development

No branches or pull requests
2 participants
@alex-w @3domennotry