Fix #725: Introduce line breaks in GenerateNotNullWhenTrueAttribute and GenerateMaybeNullWhenFalse #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eMaybeNullWhenFalse. Fixes SteveDunn#725.
danielcweber
changed the title
|
Thanks for the PR! Apologies that it's a nightmare to merge these in! The snapshots are both a help and hindrance! I'll sort this out when I'm back online, hopefully by the end of the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though the resulting snapshot changes don't match my understanding of multiline raw string literals yet, it should fix #725.
EDIT: This is based on 5.0.6 although Github won't let me choose the tag as base branch so it may require a rebase.
EDIT2: rebasing onto main contains lots of snapshot changes unrelated to the fix, so I'd need directions.