Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible MPV/memory bug in tabbed-windows branch #58

Open
ahuston-0 opened this issue Sep 29, 2021 · 2 comments
Open

Possible MPV/memory bug in tabbed-windows branch #58

ahuston-0 opened this issue Sep 29, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@ahuston-0
Copy link
Collaborator

After switching everything over to tabs in the tabbed-windows branch, testVideo and testAudio no longer produce any output. There are no obvious errors from Grail or MPV that are being emitted, but it is suspected to be a memory bug.

@ahuston-0
Copy link
Collaborator Author

Turns out that it was an issue to do with the fact that we're relying on the frame-rate to determine the update time. We fixed it by setting the framerate to 0 (continuous updates and renders), but we need to determine an alternate method of playing audio without forcing redraws.

@ahuston-0 ahuston-0 added the bug Something isn't working label Sep 29, 2021
@hydrodog
Copy link
Contributor

Not a memory issue. Audio and video require animation to be on in order to act. For video, that isn't bad. For audio, we need to create a background thread so video need not be animated in order to play sounds

@hydrodog hydrodog reopened this Sep 29, 2021
@ahuston-0 ahuston-0 linked a pull request Jan 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants