New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging should be simplified #2

Closed

eao197 opened this issue Mar 7, 2021 · 1 comment

Assignees

Labels

Member

eao197 commented Mar 7, 2021

It seems that fragment like those:

::arataga::logging::wrap_logging(
	direct_logging_mode,
	spdlog::level::debug,
	[&]( auto & logger, auto level ) {...} );

::arataga::logging::wrap_logging(
	direct_logging_mode,
	spdlog::level::trace,
	[&]( auto & logger, auto level ) {...} );

can be replaced by something like:

::arataga::logging::direct_mode::debug(
	[&]( auto & logger, auto level ) {...} );

::arataga::logging::direct_mode::trace(
	[&]( auto & logger, auto level ) {...} );

eao197 self-assigned this

eao197 added the enhancement label

Member Author

eao197 commented Jul 1, 2021

Implemented in v0.5.3.

eao197 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment