Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to API level 28 #2653

Closed
hawkrives opened this issue Jun 13, 2018 · 1 comment
Closed

Upgrade to API level 28 #2653

hawkrives opened this issue Jun 13, 2018 · 1 comment

Comments

@hawkrives
Copy link
Member

hawkrives commented Jun 13, 2018

facebook/react-native#18095 (comment)

you'll need to add android:usesCleartextTraffic="true" to your AndroidManifest.xml file.

This is only necessary for debug/development builds; please don't do this for release builds. Use manifest placeholders to set this appropriately for each build type.

@hawkrives
Copy link
Member Author

A later comment added this:


If anyone is upgrading to SDK 28, you'll need to add

android:usesCleartextTraffic="${isDebug}"

to the <application> element in your AndroidManifest.xml file, and

    buildTypes {
        debug {
            manifestPlaceholders = [isDebug:true]
        }

        release {
            manifestPlaceholders = [isDebug:false]
        }
    }

to your app/build.gradle file

@hawkrives hawkrives added this to the v2.6 milestone Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant