Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the size of PrimitiveTypesBitMapIterator #282

Closed
Stranger6667 opened this issue Oct 3, 2021 · 2 comments
Closed

Reduce the size of PrimitiveTypesBitMapIterator #282

Stranger6667 opened this issue Oct 3, 2021 · 2 comments
Labels
Difficulty: Medium Hacktoberfest Priority: Low Topic: Performance

Comments

@Stranger6667
Copy link
Owner

Now it is 3 bytes, but can be two bytes if instead of range there will be u8 as an index. The iterator is only used in validators' Display and in ValidationError display, so the impact is quite small
@pdogr pdogr mentioned this issue Oct 8, 2021
Merged
@pdogr
Copy link
Contributor

pdogr commented Oct 8, 2021

Hi, I tried to fix this in #292. Please do share your views.
Thanks!

@Stranger6667
Copy link
Owner Author

Closed via #292
Thanks @plaxi0s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: Medium Hacktoberfest Priority: Low Topic: Performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stranger6667 @pdogr