Schema with pattern re-compute regexp on each validate call

[ermakov-oleg]

Example schema:

{'pattern': '^(foo|bar)$', 'format': 'regex', 'type': 'string'}

https://github.com/Stranger6667/jsonschema-rs/blob/master/jsonschema/src/keywords/format.rs#L284-L294

[Stranger6667]

The ‘pattern’ keyword is not relevant here as the mentioned code is only for ‘format’, but indeed it verifies correctness of the input regex by trying to compile it. Not sure whether we can do anything about it besides adding some cache for inputs (but it is a a more broad issue for any validator)

[Stranger6667]

Is caching for input strings something that you were thinking about?

[Stranger6667]

I guess it could be nice to have a global cache for it - as format is universal and all ‘regex’ format validators could utilise it

[ermakov-oleg]

Hmm, really, if you don't specify "format", regexp caches fine.
Then it's just not very expected behavior...

[Stranger6667]

I don’t think there is something we can clarify from this library side as the JSON Schema spec describes this - these are two separate keywords that do not affect each others behaviour and target different things. ‘pattern’ keyword is about a pattern defined in the schema, ‘format: pattern’ is about a pattern in the input data

[ermakov-oleg]

Oh, really, I misunderstood the specification...
Sorry if I distracted you. I will close this issue.

[Stranger6667]

No worries at all! On the contrary - I think it actually an interesting opportunity to explore caching possibilities for the “pattern” format