Skip to content

Commit 2f7a29a

Browse files
committed
Fixes from review: now packaging the install tree; Debian package name and installation prefix fixed
1 parent 5130a09 commit 2f7a29a

File tree

4 files changed

+13
-17
lines changed

4 files changed

+13
-17
lines changed

.github/workflows/linux.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@ jobs:
178178
-D CMAKE_CXX_COMPILER=${{matrix.CXX_COMPILER}}
179179
-D CMAKE_CXX_EXTENSIONS=OFF
180180
-D CMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/install
181+
-D CPACK_PACKAGING_INSTALL_PREFIX=/usr
181182
-B$GITHUB_WORKSPACE/build
182183
-H$GITHUB_WORKSPACE
183184

@@ -194,7 +195,7 @@ jobs:
194195
- name: Package DEB
195196
shell: bash
196197
run: $CPACK_EXE
197-
--config "$GITHUB_WORKSPACE/build/CPackSourceConfig.cmake"
198+
--config "$GITHUB_WORKSPACE/build/CPackConfig.cmake"
198199
-G DEB
199200
-C Release
200201
-B "$GITHUB_WORKSPACE/package-deb"

.gitignore

+3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
# Build dir
22
[Bb]uild/
33

4+
# Install dir
5+
[Ii]nstall/
6+
47
# Package dir
58
[Pp]ackage[-_\s\d]*/
69

CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ if(TARGET Headers)
77
endif()
88

99
project(OpenCLHeaders
10-
VERSION 2.2
10+
VERSION 3.0
1111
LANGUAGES C # Ideally should be NONE, but GNUInstallDirs detects platform arch using try_compile
1212
# https://stackoverflow.com/questions/43379311/why-does-project-affect-cmakes-opinion-on-cmake-sizeof-void-p
1313
)

cmake/Package.cmake

+7-15
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
set(CPACK_PACKAGE_VENDOR "khronos")
22

3-
set(CPACK_PACKAGE_DESCRIPTION "OpenCL API C headers")
3+
set(CPACK_PACKAGE_DESCRIPTION "Khronos OpenCL Headers")
44

55
set(CPACK_RESOURCE_FILE_LICENSE "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE")
66

@@ -10,34 +10,26 @@ if(NOT CPACK_PACKAGING_INSTALL_PREFIX)
1010
set(CPACK_PACKAGING_INSTALL_PREFIX "${CMAKE_INSTALL_PREFIX}")
1111
endif()
1212

13-
if(NOT CPACK_SOURCE_IGNORE_FILES)
14-
set(CPACK_SOURCE_IGNORE_FILES="/.github/;/build/")
15-
endif()
16-
1713
# DEB packaging configuration
1814
set(CPACK_DEBIAN_PACKAGE_MAINTAINER ${CPACK_PACKAGE_VENDOR})
1915

2016
set(CPACK_DEBIAN_PACKAGE_HOMEPAGE
2117
"https://github.com/KhronosGroup/OpenCL-Headers")
2218

23-
# Get Debian package name from project name
24-
string(TOLOWER ${PROJECT_NAME} DEBIAN_PACKAGE_NAME)
25-
string(REPLACE "opencl" "opencl-" DEBIAN_PACKAGE_NAME ${DEBIAN_PACKAGE_NAME})
26-
2719
# Version number [epoch:]upstream_version[-debian_revision]
28-
set(CPACK_DEBIAN_PACKAGE_VERSION ${CPACK_PACKAGE_VERSION}) # upstream_version
29-
set(CPACK_DEBIAN_PACKAGE_RELEASE "1") # devian_revision (because this is a
20+
set(LATEST_RELEASE_VERSION "~2023.04.17")
21+
set(CPACK_DEBIAN_PACKAGE_VERSION ${CMAKE_PROJECT_VERSION}) # upstream_version
22+
set(CPACK_DEBIAN_PACKAGE_RELEASE "1") # debian_revision (because this is a
3023
# non-native pkg)
3124

25+
set(DEBIAN_PACKAGE_NAME "opencl-c-headers")
3226
set(CPACK_DEBIAN_PACKAGE_NAME
33-
"${CPACK_PACKAGE_VENDOR}-${DEBIAN_PACKAGE_NAME}"
27+
"${DEBIAN_PACKAGE_NAME}"
3428
CACHE STRING "Package name" FORCE)
3529

36-
set(CPACK_DEBIAN_PACKAGE_FILE_NAME "${CPACK_DEBIAN_PACKAGE_NAME}-${CPACK_DEBIAN_PACKAGE_VERSION}")
37-
3830
# Package file name in deb format:
3931
# <PackageName>_<VersionNumber>-<DebianRevisionNumber>_<DebianArchitecture>.deb
40-
set(CPACK_DEBIAN_FILE_NAME DEB-DEFAULT)
32+
set(CPACK_DEBIAN_FILE_NAME "${CPACK_PACKAGE_VENDOR}-${DEBIAN_PACKAGE_NAME}_${CPACK_DEBIAN_PACKAGE_VERSION}_${CPACK_DEBIAN_PACKAGE_ARCHITECTURE}.deb")
4133

4234
set(CPACK_DEBIAN_PACKAGE_DEBUG ON)
4335

0 commit comments

Comments
 (0)