You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe we can remove the below code block across msg_server_submit_tx.go since it is only used to get the connectionId. Then get the connectoinId from the hz by replacing connectionId with hostZone.connectionId.
owner := types.FormatICAAccountOwner(hostZone.ChainId, types.ICAAccountType_DELEGATION)
portID, err := icatypes.NewControllerPortID(owner)
if err != nil {
return errorsmod.Wrapf(sdkerrors.ErrInvalidAddress, "%s has no associated portId", owner)
}
connectionId, err := k.GetConnectionId(ctx, portID)
if err != nil {
return errorsmod.Wrapf(sdkerrors.ErrInvalidChainID, "%s has no associated connection", portID)
}
The text was updated successfully, but these errors were encountered:
@sampocs let me know if you agree with this — you pointed this out in #961 and I noticed we use the same pattern in DelegateOnHost and SetWithdrawalAddressOnHost.
I believe we can remove the below code block across
msg_server_submit_tx.go
since it is only used to get the connectionId. Then get the connectoinId from the hz by replacingconnectionId
withhostZone.connectionId
.The text was updated successfully, but these errors were encountered: