Skip to content

Device on user creation must be verified by default #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocasta181 merged 1 commit into from
Mar 10, 2023
Merged

Device on user creation must be verified by default #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/internal/unit21/evaluate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package unit21

import (
"fmt"
"testing"
"time"

Expand Down
12 changes: 11 additions & 1 deletion pkg/service/user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@ package service

import (
"os"
"time"

"github.com/String-xyz/string-api/pkg/internal/common"
"github.com/String-xyz/string-api/pkg/model"
"github.com/String-xyz/string-api/pkg/repository"
"github.com/pkg/errors"
"github.com/rs/zerolog/log"
)

type UserRequest = model.UserRequest
Expand Down Expand Up @@ -98,11 +100,19 @@ func (u user) Create(request model.WalletSignaturePayloadSigned) (UserCreateResp

// create device only if there is a visitor
device, err := u.device.CreateDeviceIfNeeded(user.Id, request.Fingerprint.VisitorId, request.Fingerprint.RequestId)

if err != nil && errors.Cause(err).Error() != "not found" {
return resp, common.StringError(err)
}

if device.Fingerprint != "" {
// validate that device on user creation
now := time.Now()
err = u.repos.Device.Update(device.Id, model.DeviceUpdates{ValidatedAt: &now})
if err == nil {
log.Err(err).Msg("Failed to verify user device")
}
}

jwt, err := u.auth.GenerateJWT(user.Id, device)
if err != nil {
return resp, common.StringError(err)
Expand Down