Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagsistant should handle fuse options as if they were from the command line #29

Open
BrainDamage opened this issue Jan 29, 2017 · 1 comment

Comments

@BrainDamage
Copy link

background:
Tagsistant FS can be mounted trough fstab using a line such as:
mountpoint repodata fuse.tagsistant options
the problem is the options array, currrently fstab ( and similar tools ) would pass options such as noauto, noatime, etc to fuse, which in turn would relay them to tagsistant, using the fuse interface, but if one wants to specify tagsistant specific flags such as no-autotagging, they'd still have to be put in such array and they'd be handled as fuse options.
by a cursory inspection of the code, Tagsistant seems to parse argv options using g_option_context_parse in tagsistant.c while fuse options are being handled by fuse_opt.c which have non-shared logic, so when trying to pass tagsistant command lines to fstab, one runs into this problem:

$ grep tagsistant /etc/fstab 
/tmp/test  /tmp/testdata   fuse.tagsistant  no-autotagging,noauto,user,auto_unmount 
$ mount /tmp/test
fuse: unknown option `no-autotagging'

since tagsistant isn't exporting its option list to fuse
the solution is to export and handle command line options to the fuse interface, it'll end up in redundant specification for options ( either as --flag,or as -o flag ), but at least one should be able to pass them trough fstab

@StrumentiResistenti
Copy link
Owner

Thanks for suggesting. I'll take care of this as soon as possible. I don't think I'll be able to implement this as quickly as I did for your previous issues, but I'll do my best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants