Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quicklook has suboptimal positioning #2191

Closed
flack opened this issue Sep 5, 2017 · 3 comments
Closed

quicklook has suboptimal positioning #2191

flack opened this issue Sep 5, 2017 · 3 comments
Assignees
Labels

Comments

@flack
Copy link
Contributor

flack commented Sep 5, 2017

The position of the quicklook overlay is always relative to the browser window. So when you have elfinder in an overlay that is not exactly centered in the middle of the screen, the position is such that only a part of the overlay is visible. See here for example:

elf1

elf2

It would be better if the overlay would be positioned relative to the elfinder root node, or alternatively, if the overlay would be attached to the document body, not the elfinder root node

@nao-pon nao-pon added the feature label Sep 5, 2017
@nao-pon nao-pon self-assigned this Sep 5, 2017
@nao-pon
Copy link
Member

nao-pon commented Sep 5, 2017

@flack There is no problem if it is placed flat on the page, so I'll add an option to deal with this problem.

commandsOptions.quicklook.contain

quicklook : {
	autoplay : true,
	width    : 450,
	height   : 300,
	// Maximum characters length to preview
	textMaxlen : 2000,
	// quicklook window must be contained in elFinder node on window open (true|false)
	contain : false,
	// preview window into NavDock (true|false)
	docked   : false,
	// Docked preview height ('auto' or Number of pixel) 'auto' is setted to the Navbar width
	dockHeight : 'auto',
	// media auto play when docked
	dockAutoplay : false,
	// MIME types to use Google Docs online viewer
	// Example ['application/pdf', 'image/tiff', 'application/vnd.ms-office', 'application/msword', 'application/vnd.ms-word', 'application/vnd.ms-excel', 'application/vnd.ms-powerpoint', 'application/vnd.openxmlformats-officedocument.wordprocessingml.document', 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet']
	googleDocsMimes : [],
	// URL of hls.js
	hlsJsUrl : '//cdnjs.cloudflare.com/ajax/libs/hls.js/0.7.11/hls.min.js',
	// URL of dash.all.js
	dashJsUrl : '//cdnjs.cloudflare.com/ajax/libs/dashjs/2.5.0/dash.all.min.js',
	// URL of run_prettify.js
	prettifyUrl : '//cdn.rawgit.com/google/code-prettify/master/loader/run_prettify.js'
},

@nao-pon nao-pon closed this as completed in 165336f Sep 5, 2017
@nao-pon
Copy link
Member

nao-pon commented Sep 5, 2017

@flack Thanks! 👍

@flack
Copy link
Contributor Author

flack commented Sep 5, 2017

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants