Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html layout (title of dialogs) #2752

Closed
johnfort opened this issue Oct 28, 2018 · 6 comments
Closed

html layout (title of dialogs) #2752

johnfort opened this issue Oct 28, 2018 · 6 comments
Assignees
@nao-pon
Labels
client css feature

Comments

@johnfort
Copy link

johnfort commented Oct 28, 2018 •
edited
Loading

Naoki Sawada plz, see the code where the dialog box are created.
Not everywhere there is a single set of css classes.

Example,
help

ui-widget-header ui-dialog-titlebar-close ui-corner-all elfinder-titlebar-button

pref

ui-widget-header ui-dialog-titlebar-close ui-corner-all elfinder-titlebar-button elfinder-titlebar-button-right

edit

ui-widget-header ui-dialog-titlebar-close ui-corner-all elfinder-titlebar-button elfinder-titlebar-button-right
@johnfort johnfort changed the title html layout (title od dialogs, tabs in dialogs) html layout (title od dialogs) Oct 28, 2018
@johnfort johnfort changed the title html layout (title od dialogs) html layout (title of dialogs) Oct 28, 2018
@nao-pon
Copy link
Member

nao-pon commented Oct 29, 2018

@johnfort Each command has its own class name in the container of the dialog.

elfinder-dialog-help, elfinder-dialog-preference and elfinder-dialog-edit.

@johnfort
Copy link
Author

Pay attention to elfinder-titlebar-button-right

@nao-pon
Copy link
Member

nao-pon commented Oct 31, 2018

@johnfort I do not understand the meaning well. The elfinder-titlebar-button-right class is given to buttons in the dialog header for Windows clients.

@nao-pon
Copy link
Member

nao-pon commented Nov 2, 2018

@johnfort Did you solve?

@johnfort
Copy link
Author

johnfort commented Nov 4, 2018 •
edited
Loading

html layout is not identical =)
stands out especially .platformWin
Check your email

@nao-pon
Copy link
Member

nao-pon commented Nov 5, 2018

@johnfort OK, I understood. Also fix the dialog header of Quicklook so that it will be outputted in the same HTML structure as other dialogs. Also, unify "elfinder-platformWin" class to "elfinder-titlebar-button-right" class.

@nao-pon nao-pon self-assigned this Nov 5, 2018
@nao-pon nao-pon closed this as completed in 8adec09 Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nao-pon nao-pon

Labels
client css feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nao-pon @johnfort