full_page: true doesn't render full page

[remy727]

Hello!

Thank you for the great gem!

I want to convert HTML that overflows width and height to PDF but it only generates PDF with the showing viewport only.

My Grover configuration:

Grover.configure do |config|
  config.options = {
    print_background: true,
    full_page: true,
    viewport: {
      width: 2527,
      height: 1287,
    }
  }
end

[abrom]

hey @remy727 I think there is a bit of a mixup here. The full_page option is only applicable for taking screenshots (as an image). See https://pptr.dev/api/puppeteer.screenshotoptions

The PDF options available are https://pptr.dev/api/puppeteer.pdfoptions

It's also not clear from your example of what you're wanting to happen? You want it to have both a fixed width/height for the viewport, but also capture overflowing content? How would that work? If the content was overflowing vertically, sure.. add another page. But if it overflows horizontally where would the content be expected to be rendered? PDFs don't allow for content to be rendered in two separate axes.

[remy727]

Hi @abrom,

Thank you for your reply.

The full_page option is only applicable for taking screenshots (as an image).

Aha, got it. I tried without it but the same result.

It's also not clear from your example of what you're wanting to happen?

So my HTML content is overflowing and shows vertical and horizontal scrollbars on my browser. With the above config, Grover doesn't generate a PDF with the full content. It just includes the content I can see without scrolling. Hope this makes sense.

[abrom]

It sounds like you need to take a look at the styling of your page. If you've got something artificially clamping the height/width of the viewport, you can't expect the browser to then expand it?? You've told it to do otherwise! 😉