Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Config Settings #71

Open
ohare93 opened this issue Nov 18, 2019 · 4 comments
Open

Default Config Settings #71

ohare93 opened this issue Nov 18, 2019 · 4 comments
Labels

Comments

@ohare93
Copy link
Contributor

ohare93 commented Nov 18, 2019

I believe it would be useful to change some default config options. I can agree with the mentality of keeping the functionality the same for existing users, and that if suddenly decks began to sort themselves when that was not expected then that could be an issue. However what about brand new users of CrowdAnki? 🤔

Specifically, I think that the default settings should be:

  • Do not move notes on Import: True
  • Sort settings: guid

The default setting is set in the ConfigSettings enum, and is only used that when the user does not already have such a config setting in their config json file. This will mean that users who already have the current version wil not be forced to change from our setting change. For people who have just / will soon upgrade to the latest version, we could notify them of the change. If we had a flag in the config settings like "Latest Version used" which we check upon launch of the application, then we could check if the version has increased, then give the user a notification of what the changes are, and that they should double check their CrowdAnki settings before using the add-on 🙂

Give this a thought 👍 😁 Lemme know what you think

@Stvad Stvad added the question label Nov 20, 2019
@Stvad
Copy link
Owner

Stvad commented Nov 20, 2019

Hey, I think the things you've mentioned here imply that CrowdAnki override the config file each time you launch it. Which is not the case afaik - as far as I can tell it only overrides it when we actually save settings (launch dialog, and then press ok)

@ohare93
Copy link
Contributor Author

ohare93 commented Nov 20, 2019

Nono, what I am saying is that when someone is using the current version (with the ConfigSettings) then it asks for a key from their config settings in Anki, if it doesn't find one then it uses our preset default value. Oh... 🤔 now I see your point. Then users of the previous version would have their old "setting" changed upon upgrade 🤔 then the best option must be to have a popup to inform them of this! 😅 and get them to set their config themselves

@Stvad
Copy link
Owner

Stvad commented Nov 20, 2019

I don't like popups 😛. I wonder if there is a generic "release notes" mechanism for plugin updates.

@ohare93
Copy link
Contributor Author

ohare93 commented Nov 20, 2019

I don't like popups 😛

Why? 😏

I wonder if there is a generic "release notes" mechanism for plugin updates.

I do not believe there is 🤔 though I have seen another add-on do a large popup with the release notes. If I can recall which one, I'll try and find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants